Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove obsolete actor #27147

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Conversation

john-bodley
Copy link
Member

SUMMARY

Previously, in #20499, I removed the unnecessary and now obsolete "actor" construct. It seems like I missed one instance.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the api Related to the REST API label Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1776405) 67.14% compared to head (646bc3f) 69.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27147      +/-   ##
==========================================
+ Coverage   67.14%   69.47%   +2.32%     
==========================================
  Files        1901     1901              
  Lines       74444    74444              
  Branches     8304     8305       +1     
==========================================
+ Hits        49989    51721    +1732     
+ Misses      22403    20670    -1733     
- Partials     2052     2053       +1     
Flag Coverage Δ
hive 53.79% <100.00%> (?)
mysql 78.00% <100.00%> (-0.01%) ⬇️
postgres 78.10% <100.00%> (-0.01%) ⬇️
presto 53.74% <100.00%> (?)
python 83.07% <100.00%> (+4.83%) ⬆️
sqlite 77.62% <100.00%> (-0.01%) ⬇️
unit 56.42% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit 986e417 into master Feb 20, 2024
40 checks passed
@john-bodley john-bodley deleted the john-bodley--remove-obsolete-actor branch February 20, 2024 20:23
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the REST API size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants