fix(explore): Allow only saved metrics and columns #27539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinpark
requested review from
Antonio-RiveroMartnez,
kgabryje,
john-bodley and
michael-s-molina
justinpark
commented
Mar 15, 2024
| col => col.column_name === (item.value as ColumnMeta).column_name, | ||
| ); | ||
| const columnName = (item.value as ColumnMeta).column_name; | ||
| return availableColumnSet.has(columnName); |
justinpark
commented
Mar 15, 2024
| }, | ||
| ); | ||
| expect( | ||
| await screen.findByText('Drop columns/metrics here or click'), | ||
| ).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test('cannot drop a column that is not part of the simple column selection', () => { |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27539 +/- ##
==========================================
+ Coverage 69.73% 69.79% +0.06%
==========================================
Files 1909 1909
Lines 74692 74722 +30
Branches 8325 8334 +9
==========================================
+ Hits 52086 52152 +66
+ Misses 20556 20517 -39
- Partials 2050 2053 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kgabryje
approved these changes
Mar 16, 2024
justinpark
added
the
v4.0
deepak-kumar-007
pushed a commit
to deepak-kumar-007/superset-forked
that referenced
this pull request
Mar 18, 2024
michael-s-molina
pushed a commit
that referenced
this pull request
Mar 19, 2024
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
EandrewJones
pushed a commit
to UMD-ARLIS/superset
that referenced
this pull request
Apr 5, 2024
mistercrunch
added
🍒 4.0.0
🏷️ bot
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Airbnb had previously overridden an option to disable ad-hoc metrics with commit #17202.
However, with the D&D option now enabled, users can accidentally drop an ad-hoc metric, thus gaining access to the previously disabled (tab) option.
To address this, the commit includes a condition to check whether the item being dropped is among the saved metrics, preventing such cases.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--adhoc-metric-drop.mov
After:
after--adhoc-metric-drop.mov
TESTING INSTRUCTIONS
Set a dataset extra with `{ "disallow_adhoc_metrics": true }'
Create a chart with the dataset and then try to drop a column to "Metric" which should be blocked
ADDITIONAL INFORMATION