Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AlertReports): disabling value when not null option is active #27550

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

fisjac
Copy link
Contributor

@fisjac fisjac commented Mar 18, 2024

SUMMARY

Adding a small change to the logic to ensure that no value is shown when "Not Null" is selected as an option.
Removed the required asterisk when not null is selected.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: image
After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: ALERT_REPORTS
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.48%. Comparing base (ae29427) to head (e42db83).
Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27550      +/-   ##
==========================================
+ Coverage   67.36%   67.48%   +0.11%     
==========================================
  Files        1909     1911       +2     
  Lines       74744    75063     +319     
  Branches     8329     8479     +150     
==========================================
+ Hits        50352    50653     +301     
+ Misses      22342    22339       -3     
- Partials     2050     2071      +21     
Flag Coverage Δ
javascript 57.52% <ø> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley
Copy link
Member

Thanks @fisjac for the fix. Would you mind adding a unit test to ensure this behavior doesn't regress in the future?

@geido geido requested review from kgabryje and geido March 19, 2024 18:14
@fisjac fisjac closed this Mar 25, 2024
@fisjac fisjac reopened this Mar 25, 2024
@geido geido merged commit ed9e542 into apache:master Mar 26, 2024
58 of 60 checks passed
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Mar 26, 2024
michael-s-molina pushed a commit that referenced this pull request Mar 26, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
@mistercrunch mistercrunch added 🍒 4.0.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Apr 17, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.0 🍒 4.0.1 🍒 4.0.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants