-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AlertReports): disabling value when not null option is active #27550
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27550 +/- ##
==========================================
+ Coverage 67.36% 67.48% +0.11%
==========================================
Files 1909 1911 +2
Lines 74744 75063 +319
Branches 8329 8479 +150
==========================================
+ Hits 50352 50653 +301
+ Misses 22342 22339 -3
- Partials 2050 2071 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks @fisjac for the fix. Would you mind adding a unit test to ensure this behavior doesn't regress in the future? |
…ache#27550) (cherry picked from commit c907470)
SUMMARY
Adding a small change to the logic to ensure that no value is shown when "Not Null" is selected as an option.
Removed the required asterisk when not null is selected.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION