docs(Database): Clarify host value expected when running in docker #28124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rusackas
reviewed
Apr 18, 2024
| @@ -44,6 +44,8 @@ or for the purposes of this walkthrough, you can click the link below all these | |||
|
|
|||
| <img src={useBaseUrl("/img/tutorial/tutorial_03a_database_connection_string_link.png" )} width="600" />{" "} <br/><br/> | |||
|
|
|||
| Please note, if you are trying to connect to another locally running database such as Clickhouse (whether on host or another container), and you get the message `The port is closed.`, then you need to adjust the HOST to `host.docker.internal` | |||
There was a problem hiding this comment.
Is there something that's likely Clickhouse-specific here, or would it be best to remove the "such as Clickhouse" to keep it generic?
rusackas
approved these changes
Jul 16, 2024
rusackas
reviewed
Jul 16, 2024
docs/docs/creating-charts-dashboards/creating-your-first-dashboard.mdx
Outdated
Show resolved
Hide resolved
When running in Docker locally and attempting to connect to another DB also running in docker, the instructions are not clear enough.
sfirke
approved these changes
Jul 16, 2024
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
…28124) Co-authored-by: Evan Rusackas <evan@preset.io>
github-actions
bot
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When running in Docker locally and attempting to connect to another DB also running in docker, the instructions are not clear enough, to help onboard new users, we should add a note clarifying what the HOST should be.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION