Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call render operator function #28132

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

eschutho
Copy link
Member

SUMMARY

Found a small bug where the render operator function was being passed in instead of executed and so the operator was undefined. I just renamed the variable so that it would sound more like a method to make it easier to catch in the future. Also added some tests.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
Screenshot 2024-04-18 at 2 30 39 PM

TESTING INSTRUCTIONS

Add a color condition to a column on the table viz

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho force-pushed the elizabeth/fix-color-comparison-bug branch from 93a3619 to 03aef52 Compare April 18, 2024 22:34
@eschutho eschutho marked this pull request as ready for review April 18, 2024 22:35
Copy link
Member

@sadpandajoe sadpandajoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eschutho eschutho merged commit 218c85a into table-time-comparison Apr 19, 2024
28 of 35 checks passed
@rusackas rusackas deleted the elizabeth/fix-color-comparison-bug branch April 19, 2024 19:48
betodealmeida pushed a commit that referenced this pull request Apr 25, 2024
eschutho added a commit that referenced this pull request Jun 5, 2024
sadpandajoe added a commit to preset-io/superset that referenced this pull request Jul 1, 2024
yousoph pushed a commit that referenced this pull request Jul 2, 2024
eschutho pushed a commit that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants