Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improves the Drill By feature #29242

Merged
merged 6 commits into from
Jun 17, 2024

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jun 13, 2024

SUMMARY

This PR improves the drill by feature by:

  • Automatically focusing the menu search field
  • Adding virtualization to the options list to handle many items
  • Diminishing the request payload by selecting only required data
  • Adding an extension point to allow custom option loaders that might filter the options list depending on the chart's form data.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2024-06-13.at.14.48.13.mov

TESTING INSTRUCTIONS

  • Check that the menu can handle many items efficiently
  • Check that the loader can be overridden
  • Check the improved request

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit 08e44c0 into apache:master Jun 17, 2024
34 checks passed
eschutho pushed a commit that referenced this pull request Jul 24, 2024
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants