Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: small fixes to the catalog migration #29579

Merged
merged 1 commit into from
Jul 13, 2024
Merged

fix: small fixes to the catalog migration #29579

merged 1 commit into from
Jul 13, 2024

Conversation

betodealmeida
Copy link
Member

SUMMARY

Some small fixes to changes introduced in #29549.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida requested a review from a team as a code owner July 12, 2024 21:19
@github-actions github-actions bot added the risk:db-migration PRs that require a DB migration label Jul 12, 2024
@dosubot dosubot bot added the change:backend Requires changing the backend label Jul 12, 2024
@betodealmeida betodealmeida merged commit a56f656 into master Jul 13, 2024
36 of 37 checks passed
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@betodealmeida @eschutho
fix: small fixes to the catalog migration (#29579)
ad3b0d7
@rusackas rusackas deleted the small-fixes-catalog-migration branch September 27, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschutho eschutho eschutho approved these changes

Assignees
No one assigned
Labels
change:backend Requires changing the backend risk:db-migration PRs that require a DB migration size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@betodealmeida @eschutho