fix: schemas for upload API #29604
Merged
fix: schemas for upload API #29604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
fix-schemas-for-upload
branch
from
635cb2f
to
1751d6a
Compare
| @@ -993,7 +993,7 @@ def get_schema_access_for_file_upload( # pylint: disable=invalid-name | |||
| self, g.user | |||
| ) | |||
| allowed_databases += extra_allowed_databases | |||
| return sorted(set(allowed_databases)) | |||
There was a problem hiding this comment.
@betodealmeida Do you know why it was sorted before?
There was a problem hiding this comment.
It was sorted so it can be displayed nicely in the UI, but since that's a UI-only concern we've been moving the sorting logic to the frontend. I'm going to update it next, for now this PR fixes only this because it's broken by returning a list.
There was a problem hiding this comment.
Should the frontend change also happen in this PR to make it atomic? This would make the PR not only fix the list issue but also preserve the current sorted behavior. In other words, there would not be any side effect as the result of this PR except the fix.
michael-s-molina
added
the
review:checkpoint
betodealmeida
force-pushed
the
fix-schemas-for-upload
branch
from
1751d6a
to
f86d327
Compare
9 tasks
rusackas
removed
the
review:checkpoint
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Make sure
get_schema_access_for_file_uploadreturns a set, so it can be used by the API.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Added unit test.
ADDITIONAL INFORMATION