Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps, deps-dev): upgrade major versions for dependencies of @superset/embedded-sdk #30242

Merged
merged 5 commits into from
Sep 12, 2024
Merged

build(deps, deps-dev): upgrade major versions for dependencies of @superset/embedded-sdk #30242

merged 5 commits into from
Sep 12, 2024

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Sep 11, 2024 •
edited by rusackas
Loading

build(deps, deps-dev): upgrade major versions for dependencies of @superset/embedded-sdk

SUMMARY

  • Upgrade major versions for dependencies of @superset/embedded-sdk
  • Fix npm audit findings

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Failed to resolve entry for package @superset-ui/switchboard #30241
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hainenber
build(deps, deps-dev): upgrade major version for deps and devDeps in …
e0706a3 
…`superset-embedded-sdk`

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
fix(sec): fix npm audit result in superset-embedded-sdk
94d7f36 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber hainenber changed the title buid(deps, deps-dev): upgrade major versions for dependencies of @superset/embedded-sdk build(deps, deps-dev): upgrade major versions for dependencies of @superset/embedded-sdk Sep 11, 2024
hainenber
hainenber commented Sep 11, 2024
View reviewed changes
superset-embedded-sdk/package.json
"axios": "^1.6.0",
"babel-loader": "^8.2.3",
"axios": "^1.7.7",
"babel-loader": "^9.1.3",
Copy link
Contributor Author

@hainenber hainenber Sep 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No breaking change for this major version upgrade except higher requirement of node, babel and webpack (source). All are satisfied by current versions.

hainenber
hainenber commented Sep 11, 2024
View reviewed changes
superset-embedded-sdk/package.json
@@ -34,20 +34,20 @@
],
"dependencies": {
"@superset-ui/switchboard": "^0.20.2",
"jwt-decode": "^3.1.2"
"jwt-decode": "^4.0.0"
Copy link
Contributor Author

@hainenber hainenber Sep 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small chance of breaking changes according to the release aside from named export change. The largest risk comes from atob polyfill drop but since the SDK's caniuses consist of all major browser's latest versions, this shouldn't be an issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Thanks for looking into it.

@hainenber
chore: bump @superset/embedded-sdk to 0.1.2
a275028 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
build(deps-dev): upgrade to Typescript 5 for @superset/embedded-sdk
94cf074 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@rusackas
Copy link
Member

rusackas commented Sep 11, 2024 •
edited
Loading

Thanks @hainenber - if you bump the patch version in package.json, this should release the new version automatically (or so it seems). This also seems to need a rebase, since I already bumped it in another PR.

Nevermind, you did! 👍

rusackas
rusackas approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks! Once this is rebased, I think it'll be good to go.

@rusackas
Copy link
Member

We're going to have to make you a committer, so you can make branches on superset and review PRs, and I can repay the favor (at least a little) by helping to rebase things for you when needed ;)

@hainenber
Merge branch 'master' into upgrade-major-versions-for-deps-of-embedde…
61e8f00 
…d-sdk-pkg

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
Copy link
Contributor Author

Rebased :D

@hainenber
Copy link
Contributor Author

Thanks @rusackas! Great power comes with great responsibility for me from now on :D

@rusackas rusackas mentioned this pull request Sep 12, 2024
Closed
3 tasks
@rusackas rusackas merged commit 8c0b873 into apache:master Sep 12, 2024
36 checks passed
@hainenber hainenber deleted the upgrade-major-versions-for-deps-of-embedded-sdk-pkg branch September 12, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
dependencies:npm embedded size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hainenber @rusackas