Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for undefined inner_time_filter in models #309

Merged

Conversation

antbell
Copy link
Contributor

@antbell antbell commented Apr 9, 2016

When not specifying a time field, the bubble chart would fail with:

local variable 'inner_time_filter' referenced before assignment
[...]
File "caravel/caravel/models.py", line 626, in query

This commit fixes the problem and adds the relative test

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 72.387% when pulling fee855580cc1d3fc8d33006624c0ba7e851749c5 on antbell:fix-inner-time-filter-no-granularity into f8e5d30 on airbnb:master.

@antbell antbell force-pushed the fix-inner-time-filter-no-granularity branch from 5089c57 to b97a634 Compare April 10, 2016 07:14
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 72.387% when pulling b97a634 on antbell:fix-inner-time-filter-no-granularity into da421bb on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 72.387% when pulling b97a634 on antbell:fix-inner-time-filter-no-granularity into da421bb on airbnb:master.

@mistercrunch mistercrunch merged commit a9af6b1 into apache:master Apr 10, 2016
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.7 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants