Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix datatable scroll height when using search box or pagination controls #3377

Merged
merged 1 commit into from
Aug 30, 2017
Merged

Fix datatable scroll height when using search box or pagination controls #3377

merged 1 commit into from
Aug 30, 2017

Conversation

mxmzdlv
Copy link
Contributor

@mxmzdlv mxmzdlv commented Aug 26, 2017

Currently the table is getting clipped at the bottom when you add pagination controls or the search box:

screen shot 2017-08-26 at 2 22 27 pm

The fix is to subtract the height of these elements in fixDataTableBodyHeight function.

@coveralls
Copy link

coveralls commented Aug 26, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 69.287% when pulling a42ad3a on mxmzdlv:fix_datatable_height into c944c61 on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.287% when pulling a42ad3a on mxmzdlv:fix_datatable_height into c944c61 on apache:master.

@malcolmflint
Copy link

also fixed in #3375

@mistercrunch mistercrunch merged commit 42dd64e into apache:master Aug 30, 2017
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mxmzdlv @coveralls @malcolmflint @mistercrunch