Filter datasources per user permissions

[aliavni]

This fixes #1434

[coveralls]

Coverage decreased (-0.1%) to 69.022% when pulling a5d9aae on aliavni:filter-datasources-per-user-permissions into 3dfdde1 on apache:master.

[coveralls]

Coverage increased (+0.07%) to 69.188% when pulling ae680a5 on aliavni:filter-datasources-per-user-permissions into 3dfdde1 on apache:master.

[xrmx]

I have a vague remember we have some sorts of helpers that returns the available datasources or permissions. [after a bit...] Maybe there's something you can reuse something from BaseSupersetView.accessible_by_user?

[aliavni]

@xrmx thanks for the feedback. I already checked BaseSupersetView.accessible_by_user, but it returns names (strings) rather than the datasource objects we need here. Plus, it queries individual databases rather than the tables and datasources tables of superset database. What do you think?

[coveralls]

Coverage increased (+0.07%) to 69.183% when pulling 2b34502 on aliavni:filter-datasources-per-user-permissions into 3dfdde1 on apache:master.

[mistercrunch]

The proper way to do this so that it applies throughout the app (CRUD, REST, ...) is this way:
https://github.com/apache/incubator-superset/blob/master/superset/views/core.py#L126

I think something similar needs to be done on top of BaseDatasource:
https://github.com/apache/incubator-superset/blob/master/superset/connectors/base/views.py#L6

[mistercrunch]

Notice: this issue has been closed because it has been inactive for 197 days. Feel free to comment and request for this issue to be reopened.