-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed filter removal bug #3458
Merged
mistercrunch
merged 4 commits into
apache:master
from
Mogball:mogball/bugfix/slice_filters
Sep 15, 2017
Merged
Fixed filter removal bug #3458
mistercrunch
merged 4 commits into
apache:master
from
Mogball:mogball/bugfix/slice_filters
Sep 15, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests for FilterControl are pretty skinny at the moment, would you mind beefing them up a tad? |
3 similar comments
2 similar comments
Added some unit tests and increased code coverage a tad bit @mistercrunch |
3 tasks
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 0.20.0
labels
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix issue #3429 and a few other UI bugs with the slice filter.
Filter
components as state, which are not updated when removing a filterarray
tostring
or vice versa does not properly transform the currently selected valuesSolutions
FilterControl
component state and modified as filters are added, removed, or changedFilter
components as propsarray
andstring
as needed