Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added /healthcheck endpoint for integrations with envoy #3819

Merged
merged 3 commits into from
Nov 10, 2017
Merged

Added /healthcheck endpoint for integrations with envoy #3819

merged 3 commits into from
Nov 10, 2017

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Nov 9, 2017

Set healthcheck for envoy to integrate and check service health. Easier for us to add endpoint vs. switching envoys reference.

lyft#2

@mistercrunch

@mistercrunch
Copy link
Member

For reference, we would have kept that in our fork but figured that with the growing popularity of Envoy (https://github.com/envoyproxy/envoy) and Envoy using healthcheck/ as a default, others might benefit from this endpoint shipping with Superset.

@coveralls
Copy link

coveralls commented Nov 9, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.006%) to 71.439% when pulling 0e4a7a6 on hughhhh:healthcheck into cbcc00c on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 71.439% when pulling 0e4a7a6 on hughhhh:healthcheck into cbcc00c on apache:master.

@coveralls
Copy link

coveralls commented Nov 9, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 71.453% when pulling d20d484 on hughhhh:healthcheck into cbcc00c on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 71.453% when pulling d20d484 on hughhhh:healthcheck into cbcc00c on apache:master.

@mistercrunch mistercrunch self-requested a review November 10, 2017 04:23
@mistercrunch mistercrunch merged commit ae8b249 into apache:master Nov 10, 2017
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@hughhhh @michellethomas
Added /healthcheck endpoint for integrations with envoy (apache#3819)
ac9d423 
* fixed mergeconflicts

* fixed mergeconflicts forreal this time

* added healthcheck test
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@hughhhh @mistercrunch
Added /healthcheck endpoint for integrations with envoy (apache#3819)
fcd21d9 
* fixed mergeconflicts

* fixed mergeconflicts forreal this time

* added healthcheck test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hughhhh @mistercrunch @coveralls