Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes default hanlding in Altered slice tag #3903

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Nov 19, 2017

Default values were not handled in AlteredSliceTag.

Related to https://github.com/apache/incubator-superset/pull/3668/files

@Mogball

Copy link
Contributor

@Mogball Mogball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mistercrunch mistercrunch merged commit 1d702f2 into apache:master Nov 20, 2017
@mistercrunch mistercrunch deleted the fix_altered branch November 20, 2017 16:43
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants