Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump sqlalchemy to 1.2.2 #4299

Merged
merged 2 commits into from
Jan 28, 2018
Merged

Bump sqlalchemy to 1.2.2 #4299

merged 2 commits into from
Jan 28, 2018

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Jan 26, 2018

While at it bump sqlalchemy-utils too.

@timifasubaa
Copy link
Contributor

LGTM

@mistercrunch mistercrunch merged commit 1b06140 into apache:master Jan 28, 2018
@john-bodley john-bodley mentioned this pull request Mar 13, 2018
Merged
@john-bodley
Copy link
Member

john-bodley commented Mar 14, 2018 •
edited
Loading

Bumping the minor version of SQLAlchemy caused a regression with Presto due additional literal escaping (https://git.musta.ch/airbnb/data/pull/50187). Note a migration is needed to remedy any datasource or slice specific SQL which already included escaping.

@mistercrunch
Copy link
Member

We've seen some MySQL has gone away messages here and there and were wondering if it could be related to this upgrade. No factual evidence here yet, just intuition.

@jeffreythewang
Copy link
Contributor

We're also having issues with the version bump related to the addition of the get_table_comment method as described here, as some postgresql-specific logic is being inherited by other db engines.

@xrmx
Copy link
Contributor Author

xrmx commented Mar 24, 2018

@jeffreythewang care to open an issue?

@jeffreythewang
Copy link
Contributor

jeffreythewang commented Mar 26, 2018 •
edited
Loading

@xrmx Yup. I just opened one here, since it is dependent on which Vertica dialect you are using, and that is the one recommended in the docs.

michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@xrmx @michellethomas
Bump sqlalchemy to 1.2.2 (apache#4299)
5770a28 
* Bump sqlalchemy to 1.2.2

Fix apache#4196

* Bump sqlalchemy-utils to 0.32.21
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@xrmx @mistercrunch
Bump sqlalchemy to 1.2.2 (apache#4299)
11d0423 
* Bump sqlalchemy to 1.2.2

Fix apache#4196

* Bump sqlalchemy-utils to 0.32.21
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xrmx @timifasubaa @john-bodley @mistercrunch @jeffreythewang