Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complete chinese translation #534

Closed
wants to merge 3 commits into from
Closed

complete chinese translation #534

wants to merge 3 commits into from

Conversation

wgzhao
Copy link

@wgzhao wgzhao commented May 29, 2016

No description provided.

@coveralls
Copy link

coveralls commented May 29, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 82.165% when pulling 3408b83 on tcloudata:master into 7d27692 on airbnb:master.

@coveralls
Copy link

coveralls commented May 29, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 82.165% when pulling 49a5229 on tcloudata:master into 7d27692 on airbnb:master.

xrmx
xrmx reviewed May 29, 2016
View reviewed changes
caravel/models.py
@@ -438,7 +438,8 @@ def dttm_converter(self, dttm):
'oracle':
"""TO_TIMESTAMP('{}', 'YYYY-MM-DD"T"HH24:MI:SS.ff6')""".format(
dttm.isoformat()),
'presto': default,
'presto': "CAST('{}' AS TIMESTAMP)".format(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks unrelated

mistercrunch
mistercrunch reviewed Jun 1, 2016
View reviewed changes
caravel/config.py
@@ -113,7 +113,7 @@
LANGUAGES = {
'en': {'flag': 'us', 'name': 'English'},
# 'fr': {'flag': 'fr', 'name': 'French'},
# 'zh': {'flag': 'cn', 'name': 'Chinese'},
'zh': {'flag': 'cn', 'name': 'Chinese'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the website mostly translated at this point? I feel like we may want to leave the default to en only until we have really good translation coverage.

Copy link
Author

@wgzhao wgzhao Jun 2, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. I try to translate which include mako template ,but also almost python files . for example .
caravel/forms.py

viz_type': SelectField(
                'Viz',
                default='table',
                choices=[(k, v.verbose_name) for k, v in viz_types.items()],
                description=_("The type of visualization to display")),
            'metrics': SelectMultipleSortableField(
                _('Metrics'), choices=datasource.metrics_combo,
                default=[default_metric],
                description=_("One or many metrics to display")),
            'metric': SelectField(
                _('Metric'), choices=datasource.metrics_combo,
                default=default_metric,
                description="Chose the metric"),
            'stacked_style': SelectField(
                _('Chart Style'), choices=self.choicify(

I fork the project and create i18n branch . I will send a new PR ASAP

@mistercrunch
Copy link
Member

Also I'm not quite sure why this broke the build... maybe rebasing would help?

@xrmx xrmx mentioned this pull request Jun 10, 2016
Closed
@mistercrunch
Copy link
Member

Build fails. Please re-open a clean PR when ready.

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@dependabot-preview @zhaoyongjie
build(deps): bump @storybook/react from 5.3.18 to 5.3.19 (apache#534)
0c6f786 
Bumps [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/app/react) from 5.3.18 to 5.3.19.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v5.3.19/app/react)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@dependabot-preview @zhaoyongjie
build(deps): bump @storybook/react from 5.3.18 to 5.3.19 (apache#534)
5398e00 
Bumps [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/app/react) from 5.3.18 to 5.3.19.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v5.3.19/app/react)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@dependabot-preview @zhaoyongjie
build(deps): bump @storybook/react from 5.3.18 to 5.3.19 (apache#534)
3124260 
Bumps [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/app/react) from 5.3.18 to 5.3.19.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v5.3.19/app/react)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@dependabot-preview @zhaoyongjie
build(deps): bump @storybook/react from 5.3.18 to 5.3.19 (apache#534)
13ce959 
Bumps [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/app/react) from 5.3.18 to 5.3.19.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v5.3.19/app/react)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wgzhao @coveralls @mistercrunch @xrmx