Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add row_limit control to line chart #5426

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jul 19, 2018

Somehow it's not possible to set the row_limit for a line chart,
resulting to a 10k cap in our environment. In some cases the user may
want more than that.

@betodealmeida @hughhhh

Somehow it's not possible to set the row_limit for a line chart,
resulting to a 10k cap in our environment. In some cases the user may
want more than that.
@codecov-io
Copy link

Codecov Report

Merging #5426 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5426   +/-   ##
=======================================
  Coverage   59.09%   59.09%           
=======================================
  Files         372      372           
  Lines       23747    23747           
  Branches     2758     2758           
=======================================
  Hits        14033    14033           
  Misses       9699     9699           
  Partials       15       15
Impacted Files Coverage Δ
superset/assets/src/explore/visTypes.jsx 57.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ce7b7...69b56bf. Read the comment docs.

@mistercrunch
Copy link
Member Author

@betodealmeida @hughhhh

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mistercrunch mistercrunch merged commit a11e47f into apache:master Jul 23, 2018
@mistercrunch mistercrunch deleted the row_limit_line branch July 23, 2018 18:54
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
Somehow it's not possible to set the row_limit for a line chart,
resulting to a 10k cap in our environment. In some cases the user may
want more than that.
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jul 27, 2018
Somehow it's not possible to set the row_limit for a line chart,
resulting to a 10k cap in our environment. In some cases the user may
want more than that.

(cherry picked from commit a11e47f)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jul 31, 2018
Somehow it's not possible to set the row_limit for a line chart,
resulting to a 10k cap in our environment. In some cases the user may
want more than that.

(cherry picked from commit a11e47f)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
Somehow it's not possible to set the row_limit for a line chart,
resulting to a 10k cap in our environment. In some cases the user may
want more than that.

(cherry picked from commit a11e47f)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
Somehow it's not possible to set the row_limit for a line chart,
resulting to a 10k cap in our environment. In some cases the user may
want more than that.

(cherry picked from commit a11e47f)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
Somehow it's not possible to set the row_limit for a line chart,
resulting to a 10k cap in our environment. In some cases the user may
want more than that.

(cherry picked from commit a11e47f)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
Somehow it's not possible to set the row_limit for a line chart,
resulting to a 10k cap in our environment. In some cases the user may
want more than that.

(cherry picked from commit a11e47f)
mistercrunch added a commit that referenced this pull request Aug 12, 2018
Somehow it's not possible to set the row_limit for a line chart,
resulting to a 10k cap in our environment. In some cases the user may
want more than that.
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
Somehow it's not possible to set the row_limit for a line chart,
resulting to a 10k cap in our environment. In some cases the user may
want more than that.
@mistercrunch mistercrunch added 🍒 0.27.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Somehow it's not possible to set the row_limit for a line chart,
resulting to a 10k cap in our environment. In some cases the user may
want more than that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🍒 0.27.0 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants