[table editor] allow selecting physical table #6046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
table_selector
branch
2 times, most recently
from
08f0da0
to
febda3c
Compare
mistercrunch
force-pushed
the
table_selector
branch
4 times, most recently
from
6edf309
to
b565d41
Compare
Codecov Report
@@ Coverage Diff @@
## master #6046 +/- ##
==========================================
- Coverage 56.22% 56.18% -0.04%
==========================================
Files 519 520 +1
Lines 23098 23177 +79
Branches 2759 2765 +6
==========================================
+ Hits 12986 13023 +37
- Misses 9702 9744 +42
Partials 410 410
Continue to review full report at Codecov.
|
mistercrunch
changed the title
|
@betodealmeida this is ready for 👀 |
|
@hughhhh @betodealmeida this is ready for review |
|
Ping! I'd like to get this through. |
mistercrunch
force-pushed
the
table_selector
branch
from
b565d41
to
84ac2b9
Compare
|
👀 👀 👀 👀 👀 👀 👀 👀 |
hughhhh
reviewed
Jan 13, 2019
| return ( | ||
| <div className="m-t-5"> | ||
| <div className="row"> | ||
| <div className="col-md-11 col-xs-11" style={{ paddingRight: '2px' }}> |
There was a problem hiding this comment.
nit: move inline-style to main.css
mistercrunch
force-pushed
the
table_selector
branch
from
6200523
to
f4eef53
Compare
mistercrunch
force-pushed
the
table_selector
branch
from
f4eef53
to
cffb69e
Compare
|
Addressed comments, merging. |
xtinec
added a commit
to lyft/incubator-superset
that referenced
this pull request
Feb 19, 2019
- Add the show metadta button, accidentally removed from PR apache#6046, back to the explore view - Remove dead code that is no longer reachable from DataSourceModal.jsx.
xtinec
added a commit
that referenced
this pull request
Feb 19, 2019
* Add show metadata button back to the explore view - Add the show metadta button, accidentally removed from PR #6046, back to the explore view - Remove dead code that is no longer reachable from DataSourceModal.jsx. * Adding additional code back to make the button function and remove more dead code.
xtinec
added a commit
that referenced
this pull request
Feb 19, 2019
* Add show metadata button back to the explore view - Add the show metadta button, accidentally removed from PR #6046, back to the explore view - Remove dead code that is no longer reachable from DataSourceModal.jsx. * Adding additional code back to make the button function and remove more dead code. (cherry picked from commit f8cf0fb)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At a high level:
TableSelectas its own component out of SqlLab's left panel as its own componentTableSelector@betodealmeida this is ready for review