Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add bot config files and update issue templates #7249

Merged
merged 2 commits into from
Apr 10, 2019

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Apr 9, 2019

SUMMARY
  • Add configuration files to enable stale, move and request-info bots.

https://probot.github.io/apps/stale/
https://probot.github.io/apps/move/
https://probot.github.io/apps/request-info/

  • Add multiple issue templates
  • Minor update to styling of the pull request template
  • Move the pull request and issue templates under .github directory.
ADDITIONAL INFORMATION
REVIEWERS

@mistercrunch @michellethomas @john-bodley @williaster

@@ -0,0 +1,35 @@
<!--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't want the license headers in templates file(?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I will update this once #7217 is completed and merged.

@@ -0,0 +1,49 @@
<!--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

@mistercrunch
Copy link
Member

mistercrunch commented Apr 9, 2019

Merged! FYI you may have to add filenames to .rat-exclude

@codecov-io
Copy link

codecov-io commented Apr 9, 2019

Codecov Report

Merging #7249 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7249      +/-   ##
==========================================
+ Coverage   64.62%   64.72%   +0.09%     
==========================================
  Files         422      425       +3     
  Lines       20593    20672      +79     
  Branches     2253     2282      +29     
==========================================
+ Hits        13309    13380      +71     
- Misses       7161     7167       +6     
- Partials      123      125       +2
Impacted Files Coverage Δ
...t/assets/src/dashboard/reducers/dashboardLayout.js 94.84% <0%> (-4.08%) ⬇️
...t/assets/src/dashboard/reducers/getInitialState.js 0% <0%> (ø) ⬆️
...ts/src/dashboard/containers/DashboardComponent.jsx 100% <0%> (ø) ⬆️
.../src/dashboard/components/gridComponents/Chart.jsx 69.73% <0%> (ø) ⬆️
...rset/assets/src/SqlLab/components/TableElement.jsx 89.18% <0%> (ø) ⬆️
...erset/assets/src/components/URLShortLinkButton.jsx 76.47% <0%> (ø) ⬆️
...erset/assets/src/dashboard/util/getDashboardUrl.js 100% <0%> (ø) ⬆️
superset/assets/src/components/Loading.jsx 100% <0%> (ø) ⬆️
...et/assets/src/dashboard/components/SliceHeader.jsx 24% <0%> (ø) ⬆️
...sets/src/dashboard/containers/DashboardBuilder.jsx 0% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9216639...14bfaa2. Read the comment docs.

# Issues with these labels will never be considered stale
exemptLabels:
- ".pinned"
- ".security"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make SIP labels exempt?

@kristw kristw merged commit 6c38cb1 into apache:master Apr 10, 2019
@kristw kristw deleted the kristw--enable-bots branch April 10, 2019 05:46
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants