Fix SQLParse when query has reserved word #7305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## lyftga #7305 +/- ##
==========================================
+ Coverage 64.58% 64.58% +<.01%
==========================================
Files 425 425
Lines 20884 20886 +2
Branches 2297 2297
==========================================
+ Hits 13488 13490 +2
Misses 7270 7270
Partials 126 126
Continue to review full report at Codecov.
|
|
ping @mistercrunch |
mistercrunch
approved these changes
May 2, 2019
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* Fix SQLParse when query has reserved word * Fix indent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
The following query cannot be parsed by
sqlparse, even though it's valid:WITH columns AS (SELECT metric FROM a), rows AS (SELECT metric FROM b) SELECT c.metric AS m1, r.metric AS m2 FROM columns c JOIN rows rThis happens because
sqlparsetreatsrowsas a reserved word, even though the query is valid in Presto.Our users have been overcoming the problem by quoting
rows. This preventssqlparsefrom treating it as a reserved word. But it's confusing to users, because the underlying engine (Presto) doesn't require it.Instead, I fixed it by following Postel's Law, and being liberal about user input.
TEST PLAN
I added a unit test that covers the bug, and another basic one.
ADDITIONAL INFORMATION
REVIEWERS