[cypress] Disable chromeWebSecurity globally #7853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
reviewed
Jul 12, 2019
superset/assets/cypress.json
Outdated
| @@ -5,6 +5,7 @@ | |||
| "ignoreTestFiles": ["**/!(*.test.js)"], | |||
| "projectId": "fbf96q", | |||
| "defaultCommandTimeout": 10000, | |||
| "chromeWebSecurity": false, | |||
There was a problem hiding this comment.
maybe sort in abc order? cc @john-bodley ;)
graceguo-supercat
force-pushed
the
gg-SetCypressGlobalSettings
branch
from
a26b981
to
8995dd9
Compare
Codecov Report
@@ Coverage Diff @@
## master #7853 +/- ##
=======================================
Coverage 65.79% 65.79%
=======================================
Files 461 461
Lines 22097 22097
Branches 2423 2423
=======================================
Hits 14539 14539
Misses 7437 7437
Partials 121 121Continue to review full report at Codecov.
|
alex-mark
pushed a commit
to alex-mark/incubator-superset
that referenced
this pull request
Jul 29, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This PR is trying to resolve the same issue in #7552. In the old PR we disable chromeWebSecurity in single test file, but recently we saw a few build failure caused by this same root cause. So this PR will set disable chromeWebSecurity globally (and see if this can fix the flaky tests).
TEST PLAN
ci.
REVIEWERS
@mistercrunch