Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for all_database_access() call #7875

Merged
merged 1 commit into from
Jul 16, 2019
Merged

bug fix for all_database_access() call #7875

merged 1 commit into from
Jul 16, 2019

Conversation

rahul-rahul-sp
Copy link
Contributor

CATEGORY

Choose one

  • [x ] Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

bug fix for all_database_access() call

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

verified locally

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@codecov-io
Copy link

codecov-io commented Jul 15, 2019

Codecov Report

Merging #7875 into master will decrease coverage by 8.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7875      +/-   ##
==========================================
- Coverage   73.96%   65.77%   -8.19%     
==========================================
  Files         107      461     +354     
  Lines       11551    22103   +10552     
  Branches        0     2423    +2423     
==========================================
+ Hits         8544    14539    +5995     
- Misses       3007     7443    +4436     
- Partials        0      121     +121
Impacted Files Coverage Δ
superset/security.py 73.96% <ø> (ø) ⬆️
superset/assets/src/components/Checkbox.jsx 100% <0%> (ø)
...ations/deckgl/layers/Polygon/PolygonChartPlugin.js 0% <0%> (ø)
...ets/src/dashboard/components/dnd/DragDroppable.jsx 94.59% <0%> (ø)
...c/visualizations/deckgl/layers/Polygon/Polygon.jsx 0% <0%> (ø)
superset/assets/src/components/EditableTitle.jsx 81.53% <0%> (ø)
superset/assets/src/setup/setupPlugins.js 0% <0%> (ø)
...t/assets/src/components/InfoTooltipWithTrigger.jsx 41.66% <0%> (ø)
.../src/dashboard/components/UndoRedoKeylisteners.jsx 9.52% <0%> (ø)
...ts/src/explore/components/ExploreActionButtons.jsx 100% <0%> (ø)
... and 345 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed99b1...2cbbd6b. Read the comment docs.

@mistercrunch mistercrunch merged commit b99a3a1 into apache:master Jul 16, 2019
alex-mark pushed a commit to alex-mark/incubator-superset that referenced this pull request Jul 29, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants