Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Adding space after -- for SQL comments #7897

Merged

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jul 18, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This PR fixes an issue where for some SQL dialects (MySQL) a SQL comment begins with two dashes -- and must be followed by at least one whitespace or control character as described here.

TEST PLAN

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

to: @graceguo-supercat @michellethomas @mistercrunch

@codecov-io
Copy link

codecov-io commented Jul 18, 2019

Codecov Report

Merging #7897 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7897   +/-   ##
=======================================
  Coverage   65.79%   65.79%           
=======================================
  Files         461      461           
  Lines       22188    22188           
  Branches     2425     2425           
=======================================
  Hits        14598    14598           
  Misses       7469     7469           
  Partials      121      121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b3e7fe...d20d4cf. Read the comment docs.

@john-bodley john-bodley merged commit ccedbea into apache:master Jul 18, 2019
@john-bodley john-bodley deleted the john-bodley--fix-sql-comments branch July 18, 2019 20:17
alex-mark pushed a commit to alex-mark/incubator-superset that referenced this pull request Jul 29, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants