Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nvd3 charts for responsive y axis fix #7915

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Jul 22, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Fixes responsive y axes when they aren't specified by the user (apache-superset/superset-ui-plugins#141)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

See screenshots in the other PR

TEST PLAN

Ensure the y axis is responsive for line charts, bar charts, and area charts

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@khtruong @kristw @graceguo-supercat

@kristw kristw merged commit 92eed8a into apache:master Jul 22, 2019
@etr2460 etr2460 deleted the erik-ritter--fix-y-axis branch July 22, 2019 21:48
etr2460 pushed a commit to airbnb/superset-fork that referenced this pull request Jul 22, 2019
alex-mark pushed a commit to alex-mark/incubator-superset that referenced this pull request Jul 29, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants