-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a bottom row that aggregates each metric column for table viz #920
Conversation
@@ -422,6 +422,12 @@ def get_df(self, query_obj=None): | |||
self.form_data.get("granularity") == "all" and | |||
'timestamp' in df): | |||
del df['timestamp'] | |||
if not self.form_data.get('all_columns'): | |||
metrics = self.form_data.get('metrics') or ['count'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's something off there as tests fails :)
Sorry this never made it in, I'm cleaning up older PRs with merge conflicts at the moment. Please resubmit the PR if you want this feature to make it in. |
+1 for anyone knowledgeable enough to get this in! |
+1 this is a nobrain for a data viz tool |
This is an old PR at this point, but still +1 to the idea. I'm looking through the project to see about implementing it myself, but I may not be knowledgeable enough on the internals of Superset to do so. |
This is a good idea, but I don't think it can be solved on the client side as proposed in this PR, as metrics need to be aggregated on the datasource (think mean, weighted average or other custom aggregation which can't simply be summed up). However, by leveraging the new chart API, this could be done fairly elegantly by issuing two |
+1 was shocked to discover this cannot be done.. I sure can add |
+1, good idea, and a very much needed feature. |
* feat(plugin-chart-echarts): subject Arrange legend and zoom * fix * WIP * Fix * set zoomable false * fix tests * Solve comments * Add constants * fix * fix lint * fix lint * fix lint * snake_case to camelCase * remove unused property
* feat(plugin-chart-echarts): subject Arrange legend and zoom * fix * WIP * Fix * set zoomable false * fix tests * Solve comments * Add constants * fix * fix lint * fix lint * fix lint * snake_case to camelCase * remove unused property
* feat(plugin-chart-echarts): subject Arrange legend and zoom * fix * WIP * Fix * set zoomable false * fix tests * Solve comments * Add constants * fix * fix lint * fix lint * fix lint * snake_case to camelCase * remove unused property
* feat(plugin-chart-echarts): subject Arrange legend and zoom * fix * WIP * Fix * set zoomable false * fix tests * Solve comments * Add constants * fix * fix lint * fix lint * fix lint * snake_case to camelCase * remove unused property
In table viz, I add a table footer that shows the sum of metric columns.
The footer can't be sorted to the top.