This repository has been archived by the owner on May 12, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
TAJO-1925: Improve hive compatibility with TIMESTAMP partition column. #853
Open
blrunner
wants to merge
38
commits into
apache:master
Choose a base branch
from
blrunner:TAJO-1925
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into TAJO-1925
I fixed some bugs and added description about timezone with hive. For the reference, I tested the patch with tpc-h 1g dataset as following:
|
…into TAJO-1925
…into TAJO-1925
…into TAJO-1925
…into TAJO-1925
…into TAJO-1925
…into TAJO-1925
…into TAJO-1925
…into TAJO-1925
…into TAJO-1925 Conflicts: tajo-plan/src/main/java/org/apache/tajo/plan/util/PartitionFilterAlgebraVisitor.java
Rebased. Basically, Tajo column partition focus on Hive partition compatibility. Currently, Hive just created timestamp partition directories using date format. I think that Tajo just need to follow current Hive version rule. Because even if we implement long value time for timestamp partition directory, Hive can't handle it. |
…O-1925 Conflicts: tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
…into TAJO-1925
…into TAJO-1925
…into TAJO-1925
…into TAJO-1925
…into TAJO-1925
…into TAJO-1925
…into TAJO-1925
…into TAJO-1925
Hi @blrunner, It has been long time. IMO, This patch needs to be included in 0.12.0 release. If you are Ok, could your rebase it? Otherwise, I can do it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch contains following modifications:
YYYY-MM-DD HH:MM:SS.MS
.And I found that the patch ran successfully with MySQLStore and HiveCatalogStore.