New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAJO-1855: Add document for tablespace configuration to the Configuration chapter. #873

Closed
wants to merge 14 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@eminency
Contributor

eminency commented Nov 24, 2015

@hyunsik , @jihoonson
I added a document describing tablespace feature -exactly speaking, for storage-site.json.
Please review that.

Thanks.

@hyunsik

This comment has been minimized.

Show comment
Hide comment
@hyunsik

hyunsik Nov 26, 2015

Member

Even though, we need more description for them, the current patch looks good to me. Later, we can improve it. I leaved some comments. Please correct them.

Member

hyunsik commented Nov 26, 2015

Even though, we need more description for them, the current patch looks good to me. Later, we can improve it. I leaved some comments. Please correct them.

eminency added some commits Nov 26, 2015

* example is fixed
* typo is fixed
Merge branch 'master' into TAJO-1855
* master:
  TAJO-1983: Improve memory usage of ExternalSortExec.
  TAJO-1967: Replace 'try finally' with 'try' with resources.
  TAJO-1947: Change Projection::setNamedExprs and getNamedExprs to set and get List<NamedExpr>.
  TAJO-1857: Rename the section of 'File Formats' to 'Data Formats' and fill compression section of the 'Table Management' chapter.
  TAJO-1862: TSQL gives user wrong URL of documentation.
  TAJO-1986: Rename the name 'option' to 'property' in TableMeta.
  TAJO-1988: Remove some duplicated codes in toString() of Projectable.
@eminency

This comment has been minimized.

Show comment
Hide comment
@eminency

eminency Nov 26, 2015

Contributor

Comments are applied.

Contributor

eminency commented Nov 26, 2015

Comments are applied.

eminency added some commits Nov 27, 2015

Merge branch 'master' into TAJO-1855
# Conflicts:
#	tajo-docs/src/main/sphinx/table_management/tablespaces.rst
@eminency

This comment has been minimized.

Show comment
Hide comment
@eminency

eminency Dec 1, 2015

Contributor

Good advices.
Comments are applied, @jihoonson

Contributor

eminency commented Dec 1, 2015

Good advices.
Comments are applied, @jihoonson

@jihoonson

This comment has been minimized.

Show comment
Hide comment
@jihoonson

jihoonson Dec 2, 2015

Contributor

+1 thanks for quick update.

Contributor

jihoonson commented Dec 2, 2015

+1 thanks for quick update.

@asfgit asfgit closed this in f2552bf Dec 2, 2015

@eminency eminency deleted the eminency:TAJO-1855 branch Mar 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment