This repository has been archived by the owner on May 12, 2021. It is now read-only.
TAJO-1855: Add document for tablespace configuration to the Configuration chapter. #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| * **space name** : Your own table space name which indicates a specific table space. Alpha-numeric characters and underscore(_) are permitted. | ||
| * **uri** : An URI address of a table space | ||
| * **config** : It is optional. You can specify it as JSON object to pass to each table space handler. |
There was a problem hiding this comment.
It should be configs instead of config.
|
Even though, we need more description for them, the current patch looks good to me. Later, we can improve it. I leaved some comments. Please correct them. |
| @@ -39,6 +42,8 @@ The following is an example for two tablespaces for hbase and hdfs: | |||
| } | |||
| } | |||
|
|
|||
| For more tails, see :doc:`conf/storage-site.json</configuration/storage-site-json>`. | |||
* typo is fixed
* master: TAJO-1983: Improve memory usage of ExternalSortExec. TAJO-1967: Replace 'try finally' with 'try' with resources. TAJO-1947: Change Projection::setNamedExprs and getNamedExprs to set and get List<NamedExpr>. TAJO-1857: Rename the section of 'File Formats' to 'Data Formats' and fill compression section of the 'Table Management' chapter. TAJO-1862: TSQL gives user wrong URL of documentation. TAJO-1986: Rename the name 'option' to 'property' in TableMeta. TAJO-1988: Remove some duplicated codes in toString() of Projectable.
|
Comments are applied. |
# Conflicts: # tajo-docs/src/main/sphinx/table_management/tablespaces.rst
| -------- | ||
|
|
||
| This is for registering storage format and custom storage handler class. | ||
| Tajo already supports HDFS, HBase, PostgreSQL, Amazon S3, Openstack Swift, etc, thus in usual cases using mentioned storages, you don't have to use ``storages`` configuration. |
There was a problem hiding this comment.
I suggest you don't have to add any ``storages`` configuration.
|
Good advices. |
| This is for registering storage format and custom storage handler class. | ||
| Tajo already supports HDFS, HBase, PostgreSQL, Amazon S3, Openstack Swift, etc, thus in usual cases using mentioned storages, you don't have to add any ``storages`` configuration. | ||
| However, if you want to use your custom storage as one of Tajo's data source, you need to add a configuration for your storage. Here is an example of HDFS storage. | ||
| See `:doc:storage_plugins/overview` for more information. |
There was a problem hiding this comment.
This is my mistake. Please fix to :doc:storage_plugins/overview``
|
+1 thanks for quick update. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hyunsik , @jihoonson
I added a document describing tablespace feature -exactly speaking, for storage-site.json.
Please review that.
Thanks.