This repository has been archived by the owner on May 12, 2021. It is now read-only.
TAJO-2043: Implement new data type and schema. #934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This patch looks good overall. I'll leave some comments soon. |
|
Hi @hyunsik, this patch contains a new design and interface of schema. So, to merge this patch with other parts completely, there will be quite a lot of issues. |
|
Hi @jihoonson, It requires a bunch of works. First of all, I'll implement some proxy to keep existing implementation while working in new approach too. Then, I'll continue to change existing implementation incrementally. |
|
Thanks. It would be great if we can do together after you implement the proxy. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.