Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

TAJO-2103: JdbcMetadataProviderBase need to differentiate between database name in DBMS and database name in Tajo. #990

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

blrunner
Copy link
Contributor

No description provided.

@hyunsik
Copy link
Member

hyunsik commented May 17, 2016

Could you explain the purpose of this patch?

See setDatabase() in the below. The variable 'database' already contains 'mapped_dbname'.

public JdbcTablespace(String name, URI uri, JSONObject config) {
    super(name, uri, config);
    setDatabase();
    setJdbcProperties();
  }

  private void setDatabase() {
    if (config.containsKey(CONFIG_KEY_MAPPED_DATABASE)) {
      database = this.config.getAsString(CONFIG_KEY_MAPPED_DATABASE);
    } else {
      database = ConnectionInfo.fromURI(uri).database();
    }
  }

But, your patch changes as the below. It's a duplicate.

public MetadataProvider getMetadataProvider() {
   return new PgSQLMetadataProvider(this, database, ConnectionInfo.fromURI(uri).database());
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants