Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEZ-4300: Download protoc automatically compile/development time #115

Merged
merged 1 commit into from
Feb 18, 2022
Merged

TEZ-4300: Download protoc automatically compile/development time #115

merged 1 commit into from
Feb 18, 2022

Conversation

abstractdog
Copy link
Contributor

No description provided.

@hadoop-yetus

This comment has been minimized.

Sign in to view
@hadoop-yetus

This comment has been minimized.

Sign in to view
@abstractdog abstractdog force-pushed the TEZ-4300 branch 2 times, most recently from 5ccd57c to bd37444 Compare April 2, 2021 08:03
@hadoop-yetus

This comment has been minimized.

Sign in to view
@hadoop-yetus

This comment has been minimized.

Sign in to view
@hadoop-yetus

This comment has been minimized.

Sign in to view
@hadoop-yetus

This comment has been minimized.

Sign in to view
@tez-yetus

This comment has been minimized.

Sign in to view
@tez-yetus

This comment was marked as outdated.

Sign in to view
@abstractdog
Copy link
Contributor Author

what do you think about this @jteagles? this would help with automatically handling different protoc versions, driven only by protobuf.version property

@jteagles
Copy link
Contributor

jteagles commented Jan 5, 2022

@abstractdog, As a project, is this needed only for Hadoop 3.x projects or is there value in branch-0.9 hadoop 2.x based projects?

@abstractdog
Copy link
Contributor Author

it makes sense to try the patch out on branch-0.9 as it's only about using protobuf inside tez, let me try

@abstractdog abstractdog closed this Jan 6, 2022
@abstractdog abstractdog reopened this Jan 6, 2022
@abstractdog
Copy link
Contributor Author

checked, the patch works on branch-0.9 too, this commit

contains a fix that I added on master too, please refer to the second commit: moved the profile to root pom.xml + redefined where it was needed

is this okay to go in?

@tez-yetus

This comment was marked as outdated.

Sign in to view
@abstractdog
Copy link
Contributor Author

@jteagles : can I merge this to master? and push it to branch-0.9

@tez-yetus

This comment was marked as outdated.

Sign in to view
@abstractdog abstractdog force-pushed the TEZ-4300 branch 2 times, most recently from fad5021 to 9f3f3c8 Compare February 18, 2022 12:11
@tez-yetus

This comment was marked as outdated.

Sign in to view
@abstractdog
Copy link
Contributor Author

abstractdog commented Feb 18, 2022 •
edited
Loading

@jteagles : could you please approve this patch?
the installer script has been updated according to comments in Jira, now it supports aarch64 too

@tez-yetus

This comment was marked as outdated.

Sign in to view
@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 5m 29s Maven dependency ordering for branch
+1 💚 mvninstall 9m 21s master passed
+1 💚 compile 3m 37s master passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 compile 3m 12s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javadoc 3m 28s master passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 2m 48s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 5m 20s the patch passed
+1 💚 compile 3m 34s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javac 3m 34s the patch passed
+1 💚 compile 3m 14s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 3m 14s the patch passed
-1 ❌ shellcheck 0m 0s The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 4s The patch has no ill-formed XML file.
+1 💚 javadoc 3m 20s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 2m 46s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
_ Other Tests _
+1 💚 unit 2m 20s tez-api in the patch passed.
+1 💚 unit 0m 36s tez-protobuf-history-plugin in the patch passed.
+1 💚 unit 70m 14s root in the patch passed.
+1 💚 asflicense 1m 21s The patch does not generate ASF License warnings.
122m 58s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-115/13/artifact/out/Dockerfile
GITHUB PR #115
JIRA Issue TEZ-4300
Optional Tests dupname asflicense shellcheck shelldocs javac javadoc unit xml compile
uname Linux a7c009e00555 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / a495fb6
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
shellcheck https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-115/13/artifact/out/diff-patch-shellcheck.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-115/13/testReport/
Max. process+thread count 2099 (vs. ulimit of 5500)
modules C: tez-api tez-plugins/tez-protobuf-history-plugin . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-115/13/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

jteagles
jteagles approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@jteagles jteagles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Let's try this out.

@jteagles jteagles merged commit 5241f58 into apache:master Feb 18, 2022
asfgit pushed a commit that referenced this pull request Feb 19, 2022
@abstractdog
TEZ-4300: Download protoc automatically compile/development time (#115)
23a855c
LA-Toth added a commit to LA-Toth/tez that referenced this pull request Feb 22, 2022
@LA-Toth
Revert "TEZ-4300: Download protoc automatically compile/development t…
24860be 
…ime (apache#115)"

This reverts commit 5241f58.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jteagles jteagles jteagles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abstractdog @hadoop-yetus @tez-yetus @jteagles