TEZ-4383: upgrade to mockito 4.3.1 #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
abstractdog
reviewed
Feb 18, 2022
| deserialized.readFields(new DataInputStream(new ByteArrayInputStream(bos.toByteArray()))); | ||
| verifyResults(entityDescriptor, deserialized, payload, confVal); | ||
| } | ||
|
|
||
| @Test (timeout=1000) | ||
| @Test (timeout=3000) |
There was a problem hiding this comment.
is this change needed?
There was a problem hiding this comment.
I'm not sure. Initially this test timed out with the original timeout value. I double check this one.
abstractdog
reviewed
Feb 18, 2022
| import static org.mockito.Mockito.verify; | ||
| import static org.mockito.Mockito.when; | ||
| import static org.mockito.ArgumentMatchers.any; | ||
| import static org.mockito.Mockito.*; |
There was a problem hiding this comment.
please remove wildcard import, we usually refrain from doing that
by removing it we can stay consistent with other parts of the code
There was a problem hiding this comment.
Cool, OK, consistency is also important for me.
But the tests don't always do that, namely the any() and the other matchers can be imported both as org.mockito.Mockito.any and as org.mockito.ArgumentMatchers.any. I would keep only one of these. The org.mockito.Mockito.any seems to be the better choice.
There was a problem hiding this comment.
this looks confusing from mockito side, can you please clarify the difference between them?
There was a problem hiding this comment.
These are the same. Basically the same code (function) is added to both the ArgumentMatchers and the Mockito classes. So in theory there is no real difference.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
💔 -1 overall
This message was automatically generated. |
|
mvn install failures are not related, patch LGTM, let's merge the change and then we can see if the issue persists |
abstractdog
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.