TEZ-4399: ShuffleHandler fails with SSLHandshakeException not found when SSL is enabled #196

himanshu-mishra · 2022-03-30T10:49:14Z

Shuffle handler fails with ClassNotFound org.apache.tez.shaded.javax.net.ssl.SSLHandshakeException
when SSL is enabled. Excluding shading of javax.net.** from
tez-aux-services uber jar.

DagDeleteTracker is hardcoded to generate URL with http. Fixing it to
use https when SSL config is enabled.

tez-yetus · 2022-03-30T11:44:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	18m 14s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	5m 7s	Maven dependency ordering for branch
+1 💚	mvninstall	9m 40s	master passed
+1 💚	compile	1m 4s	master passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	0m 58s	master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 3s	master passed
+1 💚	javadoc	1m 6s	master passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 50s	master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗	spotbugs	0m 39s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 14s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 8s	Maven dependency ordering for patch
+1 💚	mvninstall	0m 51s	the patch passed
+1 💚	compile	0m 47s	the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	0m 47s	the patch passed
+1 💚	compile	0m 40s	the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 40s	the patch passed
+1 💚	checkstyle	0m 26s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 35s	the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 32s	the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	findbugs	1m 49s	the patch passed
		_ Other Tests _
+1 💚	unit	4m 22s	tez-dag in the patch passed.
+1 💚	unit	2m 37s	tez-aux-services in the patch passed.
+1 💚	asflicense	0m 21s	The patch does not generate ASF License warnings.
		54m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-196/1/artifact/out/Dockerfile
GITHUB PR	#196
JIRA Issue	TEZ-4399
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile xml
uname	Linux 693939c7dc70 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / `f724c54`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-196/1/testReport/
Max. process+thread count	1402 (vs. ulimit of 5500)
modules	C: tez-dag tez-plugins/tez-aux-services U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-196/1/console
versions	git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…hen SSL is enabled Shuffle handler fails with ClassNotFound org.apache.tez.shaded.javax.net.ssl.SSLHandshakeException when SSL is enabled. Excluding shading of javax.net.** from tez-aux-services uber jar. Few places have hardcoded ssl parameter to generate URL with http. Fixing them to use https when SSL config is enabled. Respect SSL config in Vertex and TaskAttempt runnables

tez-yetus · 2022-03-30T13:32:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	4m 56s	Maven dependency ordering for branch
+1 💚	mvninstall	9m 37s	master passed
+1 💚	compile	1m 6s	master passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 59s	master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 3s	master passed
+1 💚	javadoc	1m 4s	master passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 50s	master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗	spotbugs	0m 39s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 13s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 9s	Maven dependency ordering for patch
+1 💚	mvninstall	0m 51s	the patch passed
+1 💚	compile	0m 47s	the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 47s	the patch passed
+1 💚	compile	0m 39s	the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 39s	the patch passed
+1 💚	checkstyle	0m 26s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 36s	the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 33s	the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	findbugs	1m 50s	the patch passed
		_ Other Tests _
+1 💚	unit	4m 20s	tez-dag in the patch passed.
+1 💚	unit	2m 39s	tez-aux-services in the patch passed.
+1 💚	asflicense	0m 20s	The patch does not generate ASF License warnings.
		37m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-196/2/artifact/out/Dockerfile
GITHUB PR	#196
JIRA Issue	TEZ-4399
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile xml
uname	Linux a641f0ea6a00 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / `f724c54`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-196/2/testReport/
Max. process+thread count	1415 (vs. ulimit of 5500)
modules	C: tez-dag tez-plugins/tez-aux-services U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-196/2/console
versions	git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

himanshu-mishra · 2022-04-01T06:11:03Z

Thanks @abstractdog for the review and approval. Could you please merge the PR ?

abstractdog · 2022-04-01T08:45:20Z

merged to master, thanks @himanshu-mishra for the patch!

…hen SSL is enabled (#196) (Himanshu Mishra reviewed by Laszlo Bodor)

abstractdog self-requested a review March 30, 2022 16:03

abstractdog approved these changes Mar 30, 2022

View reviewed changes

abstractdog merged commit 3e452e9 into apache:master Apr 1, 2022

asfgit pushed a commit that referenced this pull request Apr 1, 2022

TEZ-4399: ShuffleHandler fails with SSLHandshakeException not found w…

519e31b

…hen SSL is enabled (#196) (Himanshu Mishra reviewed by Laszlo Bodor)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TEZ-4399: ShuffleHandler fails with SSLHandshakeException not found when SSL is enabled #196

TEZ-4399: ShuffleHandler fails with SSLHandshakeException not found when SSL is enabled #196

himanshu-mishra commented Mar 30, 2022

tez-yetus commented Mar 30, 2022

tez-yetus commented Mar 30, 2022

himanshu-mishra commented Apr 1, 2022

abstractdog commented Apr 1, 2022

TEZ-4399: ShuffleHandler fails with SSLHandshakeException not found when SSL is enabled #196

TEZ-4399: ShuffleHandler fails with SSLHandshakeException not found when SSL is enabled #196

Conversation

himanshu-mishra commented Mar 30, 2022

tez-yetus commented Mar 30, 2022

tez-yetus commented Mar 30, 2022

himanshu-mishra commented Apr 1, 2022

abstractdog commented Apr 1, 2022