TEZ-4501: Fix TestLocalMode timeouts #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you please take a look at this @rbalamohan , @bikassaha ? simple fix in AsyncDispatcher |
This comment was marked as outdated.
This comment was marked as outdated.
ayushtkn
reviewed
Jul 12, 2023
Comment on lines
379
to
385
| // this is needed because in serviceStop we're looping to drain the rest of the events and checking !drained | ||
| // in that case, an interruption here would lead to an empty queue with drained=false, leading to | ||
| // a useless loop with a timeout (this can even cause unit test timeouts) | ||
| drained = eventQueue.isEmpty(); | ||
| LOG.info( | ||
| "Setting drained to {} due to interruption while putting a new event, stopped: {}, blockNewEvents: {}", | ||
| drained, stopped, blockNewEvents); |
There was a problem hiding this comment.
why in serviceStop we don't directly check eventQueue.isEmpty?
There was a problem hiding this comment.
eh, right, let me try that :)
NOTE: even if it works, I'll have to check the special meaning of having a separate boolean
There was a problem hiding this comment.
I tried to look out for reasons for separate boolean, but didn't find anything reasonable, maybe the coding style then...
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.