TINKERPOP-2106 throw TimeoutException instead of TraversalInterruptedException #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Exception When gremlin executes timeout, it throws an error "TraversalInterruptedException: null". According to our user feedback, the message is not easy to understand. We think it is clearer if it prompts timeout error directly. This commit converts some InterruptedException to a TimeoutException.
javeme
force-pushed
the
timeout-interrupted
branch
from
c40cdbc
to
190df79
Compare
|
i was a bit hesitant about this one at first, but perhaps this makes sense. looking at the All tests pass with VOTE +1 |
|
Merge to tp33/master with c923564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2106
When gremlin executes timeout, it throws an error "TraversalInterruptedException: null".
According to our user feedback(https://github.com/hugegraph/hugegraph/issues/102), the message is not easy to understand. we think it is clearer if it prompts timeout error directly.
This commit converts some InterruptedException to a TimeoutException.