[TINKERPOP-2891] Improved handling for negative values in CountStrategy #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiazcy
reviewed
Apr 13, 2023
| @@ -178,7 +178,7 @@ public void apply(final Traversal.Admin<?, ?> traversal) { | |||
| } | |||
| } | |||
| } else { | |||
| TraversalHelper.insertBeforeStep(new RangeGlobalStep<>(traversal, 0L, highRange), curr, traversal); | |||
| TraversalHelper.insertBeforeStep(new RangeGlobalStep<>(traversal, 0L, highRange < 0 ? 0 : highRange), curr, traversal); | |||
There was a problem hiding this comment.
It looks like highRange is a Long, should these comparisons be in Long too?
Suggested change
| TraversalHelper.insertBeforeStep(new RangeGlobalStep<>(traversal, 0L, highRange < 0 ? 0 : highRange), curr, traversal); | |
| TraversalHelper.insertBeforeStep(new RangeGlobalStep<>(traversal, 0L, highRange < 0L ? 0L : highRange), curr, traversal); |
There was a problem hiding this comment.
widening casting should handle this
There was a problem hiding this comment.
Yes, this is more of a nit style/format comment since previous comparisons are done as Long.
|
VOTE +1 |
Codecov Report
@@ Coverage Diff @@
## 3.5-dev #2021 +/- ##
=============================================
- Coverage 69.33% 64.16% -5.18%
=============================================
Files 866 25 -841
Lines 41219 3750 -37469
Branches 5432 0 -5432
=============================================
- Hits 28581 2406 -26175
+ Misses 10722 1166 -9556
+ Partials 1916 178 -1738 see 841 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
VOTE+1 |
|
VOTE +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed optimization of
countstep insideCountStrategy.queries like
g.V().where(__.in().count().is(eq(-3)))andg.V().where(__.in().count().is(eq(-2)))are now correctly optimized asg.V().where(__.in().limit(0).count().is(eq(-2)))https://issues.apache.org/jira/browse/TINKERPOP-2891