TINKERPOP-1589 Re-introduced CloseableIterator #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made it so that the CloseableIterator is closed by GraphStep if it is provided by the iterator supplier. Furthermore, any steps in a Traversal implement AutoCloseable then its close() method will be called.
|
Nice. Clean backwards compatible Are you looking for a VOTE now or are you still building on this PR? -- e.g. integrating it with |
|
I think I'm done - It's already implemented on |
okram
reviewed
Jan 5, 2017
| @@ -254,9 +254,14 @@ public default void forEachRemaining(final Consumer<? super E> action) { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Releases resources opened in any steps that implement {@link AutoCloseable}. | |||
| */ | |||
| @Override | |||
| public default void close() throws Exception { | |||
There was a problem hiding this comment.
This is bad. Steps that are TraversalParents are responsible for propagating operations on them to those below. I would do the following:
// Traversal.close()
for(final Step<?,?> step : this.getSteps()) {
if(step instanceof AutoCloseable)
step.close();
}
Next, I would have TraversalParent extend AutoCloseable with its default close() method being:
// TraversalParent.close()
for(final Traversal.Admin<?,?> traversal : this.getLocalChildren()) {
traversal.close()
}
for(final Traversal.Admin<?,? traversal: this.getGlobalChildren()) {
traversal.close();
}
There was a problem hiding this comment.
changes are made now - thanks - didn't know that stuff.
Implemented AutoCloseable on TraversalParent.
|
VOTE +1 |
1 similar comment
|
VOTE +1 |
|
VOTE: +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-1589
Made it so that the
CloseableIteratoris closed byGraphStepif it is provided by the iterator supplier. Furthermore, any steps in aTraversalimplementAutoCloseablethen itsclose()method will be called. In this wayTraversal.close(), the common API a user will work with, has a way to release resources inGraphimplementations that require it.Builds with
docker/build.sh -t - i -n.