Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TINKERPOP-1560 Used ManagedConcurrentValueMap in GremlinGroovyClassLoader #541

Merged
merged 1 commit into from
Jan 30, 2017
Merged

TINKERPOP-1560 Used ManagedConcurrentValueMap in GremlinGroovyClassLoader #541

merged 1 commit into from
Jan 30, 2017

Commits on Jan 23, 2017

  1. TINKERPOP-1560 Used ManagedConcurrentValueMap in GremlinGroovyClassLo… 

    …ader

By configuring the ManagedConcurrentValueMap to have weak references, the GremlinGroovyClassLoader, and therefore the GremlinGroovyScriptEngine, are now able to "forget" classes that are no longer used. It was determined that the cache of these classes would grow indefinitely for each script passed to the GremlinGroovyScriptEngine, thus allowing the metaspace to continue to grow. It isn't really possible to write tests to verify that this change works, but I did test manually by watching memory usage in a profiler and could see that metaspace memory stayed stable and that classes were unloading from the classloader over time.
    @spmallette
    spmallette committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    9726577 View commit details
    Browse the repository at this point in the history