TINKERPOP-1610 Deprecated Groovy test suites #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graph Providers no longer need to implement these going forward.
|
VOTE: +1 |
|
VOTE +1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-1610
Graph Providers no longer need to implement these going forward. Note that the new model for testing groovy will be similar to the approach taken for gremlin-python (which obviously doesn't have all this tests required of the provider). By making this change, we reduce the testing burden on graph providers as this is a whole body of tests they can just ignore now. This is a non-breaking change and will setup for removal and migration of the
gremlin-groovy-testclasses togremlin-groovy(or potentallygremlin-testif the test is general enough to aid in testing theGremlinScriptEngineenvironment).This is a pretty simple PR at this point, but since it was a major deprecation I wanted to go through the vote process rather than CTR.
VOTE +1