Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TINKERPOP-1271: Refactor SparkContext creation and handling of sc.stop() #555

Merged
merged 2 commits into from
Feb 15, 2017
Merged

TINKERPOP-1271: Refactor SparkContext creation and handling of sc.stop() #555

merged 2 commits into from
Feb 15, 2017

Conversation

artem-aliev
Copy link 

org.apache.tinkerpop.gremlin.spark.structure.Spark is a SparkContext holder for SparkGraphComputer.
It was refactored to detect external stop calls and recreate SparkContext in that case.
Context creation process was reordered to make all configuration options take effect.
Spark.create() methods return created context now.
The external stop also requires SPARK-18751 fix, that was integrated into Spark 2.1.
By the way the refactoring and configuration loading part gives effect on all versions.

artemaliev added 2 commits February 2, 2017 15:15
TINKERPOP-1271: Refactor SparkContext creation and handling of extern…
6bea8a5 
…al sc.stop()

    org.apache.tinkerpop.gremlin.spark.structure.Spark is a SparkContext holder for SparkGraphComputer.
    It was refactored do detect external stop calls and recreate SparkContext in that case.
    Context creation process was reordered to make all configuration options to take effect.
    Spark.create() methods return created context now.
    The external stop also requires SPARK-18751 fix, that was integrated into Spark 2.1.
    By the way the refactoring and configuration loading part gives effect on all versions.
TINKERPOP-1271: update change log
dce8404
@okram
Copy link
Contributor

okram commented Feb 3, 2017

VOTE +1.

@spmallette
Copy link
Contributor

All tests pass with docker/build.sh -t -n -i

VOTE +1

@dkuppitz
Copy link
Contributor

VOTE: +1

@asfgit asfgit merged commit dce8404 into apache:tp32 Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@artem-aliev @okram @spmallette @dkuppitz @asfgit