Increment ReleaseIdle Counter when testAllIdle releases them #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, you are right. It does seem to have been overlooked. |
aooohan
approved these changes
Aug 4, 2023
aooohan
added a commit
that referenced
this pull request
Aug 4, 2023
Fix the releaseIdleCounter does not increment when testAllIdle releases them. Pull request #241 provided by Arun Chaitanya Miriappalli
aooohan
added a commit
that referenced
this pull request
Aug 4, 2023
Fix the releaseIdleCounter does not increment when testAllIdle releases them. Pull request #241 provided by Arun Chaitanya Miriappalli
aooohan
added a commit
that referenced
this pull request
Aug 4, 2023
Fix the releaseIdleCounter does not increment when testAllIdle releases them. Pull request #241 provided by Arun Chaitanya Miriappalli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Tomcat JDBC module, I reckon PoolCleaner cleans the idle connections in two ways
releasedIdleCountis incremented when released fromcheckIdlebut not fromtestAllIdle. Is it part of the design? If so, why is it not counted?IMO, the counter should be incremented in
testAllIdletoo. This PR includes this change.