Parameter error handling #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change look good for me. |
|
Thanks for the review. I checked the various getParameter() methods and found a couple I thought needed a try/catch block. The remainder were all used in webapps or in APIs called by applications and I think throwing the exception is OK in those cases. |
aooohan
approved these changes
Aug 21, 2023
markt-asf
force-pushed
the
parameter-error-handling
branch
2 times, most recently
from
1ddbaa8
to
1ce49d5
Compare
michael-o
reviewed
Aug 21, 2023
markt-asf
force-pushed
the
parameter-error-handling
branch
from
1ce49d5
to
264fb18
Compare
This includes removing the FailedRequestFilter
markt-asf
force-pushed
the
parameter-error-handling
branch
from
264fb18
to
335348c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the parameter error handling to align with the changes in Jakarta Servlet 6.0
The short version is all getParameterXXX() calls now throw exceptions on invalid parameters.
Note that getParts() still needs to work even if the query string parameters are invalid.
I'm providing this as a PR to give folks a chance to review it before it is merged given that it is a significant change.