Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOMEE-4284 - Implement tomee.mp.jwt.allow.no-exp property over mp.jwt.tomee.allow.no-exp #1086

Merged
merged 8 commits into from
Dec 6, 2023

Conversation

tichovz
Copy link
Contributor

@tichovz tichovz commented Dec 3, 2023

This is instead of pull request #990: TOMEE-4284 - Implement tomee.mp.jwt.allow.no-exp property over mp.jwt.tomee.allow.no-exp
#990

@tichovz
Copy link
Contributor Author

tichovz commented Dec 3, 2023

I included the feedback provided by Romain. But this code does not give deprecation warning when both properties present
in the config. If this is not a problem, I will remove this requirement from the itests, because there are two tests that expect a warning to be given in this case as well.

David asked for this: "any use of mp.jwt.tomee.allow.no-exp should get a warning log message"

@tichovz tichovz changed the title Tomee 4284 TOMEE-4284 - Implement tomee.mp.jwt.allow.no-exp property over mp.jwt.tomee.allow.no-exp Dec 4, 2023
@jgallimore jgallimore merged commit fe14799 into apache:main Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants