Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite /profiles/name/{{name}}/copy/{{fromName}} to Go #3813

Closed
1 task done
ocket8888 opened this issue Aug 6, 2019 · 2 comments · Fixed by #4204
Closed
1 task done

Rewrite /profiles/name/{{name}}/copy/{{fromName}} to Go #3813

ocket8888 opened this issue Aug 6, 2019 · 2 comments · Fixed by #4204
Labels
tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Milestone

Comments

@ocket8888
Copy link
Contributor

ocket8888 commented Aug 6, 2019

I'm submitting an ...

improvement request (usability, performance, tech debt, etc.)

Traffic Control components affected ...

  • Documentation (possibly)
  • Traffic Ops

Current behavior:

/profiles/name/{{name}}/copy/{{fromName}} is handled by Perl

Expected / new behavior:

/profiles/name/{{name}}/copy/{{fromName}} should be handled by Go.

Minimum API Version

1.1

Request Methods

  • POST

Minimal reproduction of the problem with instructions:

N/A

@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops tech debt rework due to choosing easy/limited solution labels Aug 6, 2019
@ocket8888 ocket8888 added this to the Go Rewrite milestone Aug 13, 2019
@mitchell852
Copy link
Member

mitchell852 commented Sep 11, 2019

i think this should be deprecated (not rewritten to Go and a deprecation notice added to the perl response) because....weird...

also, if your intent is to clone a profile, you can do that with import/export i believe.

@rawlinp
Copy link
Contributor

rawlinp commented Sep 13, 2019

I believe TP uses this endpoint for cloning profiles. I think ops probably uses this one quite a bit, so I'm unsure about deprecating it. It's one of those things that could be done using the other APIs, but this acts like a kind of "bulk create" API instead of just creating a new profile with one call, creating all the parameters with individual calls, and associating the parameters to the profile with individual calls.

jheitz200 pushed a commit to jheitz200/trafficcontrol that referenced this issue Dec 12, 2019
…}` in Go

other minor changes on the files touched
rawlinp pushed a commit that referenced this issue Dec 16, 2019
…Go (#4204)

* Fixes #3813 implement `/profiles/name/{{name}}/copy/{{fromName}}` in Go

other minor changes on the files touched

* fixing a few typos

* fixing a typo an err returned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants