Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TO Go put deliveryservices/id/safe #2455

Closed
wants to merge 1 commit into from
Closed

Add TO Go put deliveryservices/id/safe #2455

wants to merge 1 commit into from

Conversation

rob05c
Copy link
Member

@rob05c rob05c commented Jun 22, 2018 •
edited by ocket8888
Loading

Rewrites /deliveryservices/{{id}}/safe to Go. Closes #3786

@rob05c rob05c added new feature A new feature, capability or behavior Traffic Ops API (golang) labels Jun 22, 2018
@rob05c rob05c mentioned this pull request Jun 22, 2018
Closed
@asfgit
Copy link
Contributor

asfgit commented Jun 22, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1888/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jun 22, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1894/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jul 1, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1949/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jul 1, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1952/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jul 9, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2053/
Test PASSed.

@ocket8888 ocket8888 mentioned this pull request Aug 6, 2019
Closed
1 task
@asfgit
Copy link
Contributor

asfgit commented Aug 15, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4148/
Test FAILed.

@mhoppa
Copy link
Contributor

mhoppa commented Oct 10, 2019

retest this please

@asf-ci
Copy link
Contributor

asf-ci commented Oct 11, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4450/

@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops tech debt rework due to choosing easy/limited solution and removed new feature A new feature, capability or behavior labels Oct 24, 2019
@mitchell852 mitchell852 added this to the Go Rewrite milestone Oct 24, 2019
@ocket8888 ocket8888 self-assigned this Nov 12, 2019
@asf-ci
Copy link
Contributor

asf-ci commented Nov 13, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4779/

ocket8888
ocket8888 reviewed Nov 14, 2019
View reviewed changes
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments

lib/go-tc/deliveryservices.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v13/deliveryservicesafe_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v13/deliveryservicesafe_test.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/deliveryservice/safe.go Show resolved Hide resolved
traffic_ops/traffic_ops_golang/deliveryservice/safe.go Outdated Show resolved Hide resolved
@ocket8888
Copy link
Contributor

Also can you rebase this?

@rob05c rob05c force-pushed the to-go-ds-safe branch 2 times, most recently from 83b2b2a to 1563cdb Compare December 30, 2019 18:18
@rob05c
Copy link
Member Author

rob05c commented Dec 30, 2019

Rebased, addressed all comments, ran tests again, API tests still pass, unit tests still pass.

@mhoppa
Copy link
Contributor

mhoppa commented Feb 4, 2020

updated feedback in rob05c#7 once merge I think this should be good to be merged

@ocket8888 ocket8888 mentioned this pull request Feb 10, 2020
Merged
7 tasks
@ocket8888
Copy link
Contributor

Superseded by #4388

@ocket8888 ocket8888 closed this Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocket8888 ocket8888 ocket8888 requested changes

@rawlinp rawlinp rawlinp left review comments

Assignees

@ocket8888 ocket8888

Labels
abandoned tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
Go Rewrite
Development

Successfully merging this pull request may close these issues.

Rewrite /deliveryservices/{{id}}/safe to Go
7 participants
@rob05c @asfgit @mhoppa @asf-ci @ocket8888 @rawlinp @mitchell852