Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate /servercheck/aadata #4364

Merged
merged 1 commit into from
Jan 31, 2020
Merged

deprecate /servercheck/aadata #4364

merged 1 commit into from
Jan 31, 2020

Conversation

ocket8888
Copy link
Contributor

@ocket8888 ocket8888 commented Jan 31, 2020 •
edited
Loading

What does this PR (Pull Request) do?

  • This PR fixes Rewrite /servercheck/aadata to Go #3831
    Adds a deprecation notice for /servercheck/aadata. The endpoint doesn't appear to do anything, and is undocumented, so there are no tests or documentation updates.

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Build TO (Perl implementation) and observe deprecation notices in the responses to /servercheck/aadata.

The following criteria are ALL met by this PR

  • Tests are unnecessary
  • I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops tech debt rework due to choosing easy/limited solution labels Jan 31, 2020
@ocket8888 ocket8888 added this to the Go Rewrite milestone Jan 31, 2020
mhoppa
mhoppa approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@mhoppa mhoppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rawlinp rawlinp merged commit 527790d into apache:master Jan 31, 2020
@ocket8888 ocket8888 deleted the deprecate-servercheck/aadata branch January 31, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawlinp rawlinp rawlinp approved these changes

@mhoppa mhoppa mhoppa approved these changes

Assignees
No one assigned
Labels
tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
Go Rewrite
Development

Successfully merging this pull request may close these issues.

Rewrite /servercheck/aadata to Go
3 participants
@ocket8888 @rawlinp @mhoppa