Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache promote plugin takes too much calculating size of LRUList #1336

Closed
vmamidi opened this issue Jan 18, 2017 · 0 comments · Fixed by #1337
Closed

cache promote plugin takes too much calculating size of LRUList #1336

vmamidi opened this issue Jan 18, 2017 · 0 comments · Fixed by #1337
Assignees
Labels
Milestone

Comments

@vmamidi
Copy link
Contributor

vmamidi commented Jan 18, 2017

pstack shows that cache promote plugin spends lot of time calculating too much time in determining the size of LRUList

#0 std::__distance<std::_List_const_iterator<std::pair<LRUHash, unsigned int> > > (__last=..., __first=...) at /opt/gcc/include/c++/4.9.3/bits/stl_iterator_base_funcs.h:83
#1 std::distance<std::_List_const_iterator<std::pair<LRUHash, unsigned int> > > (__last=..., __first=...) at /opt/gcc/include/c++/4.9.3/bits/stl_iterator_base_funcs.h:118
#2 std::list<std::pair<LRUHash, unsigned int>, std::allocator<std::pair<LRUHash, unsigned int> > >::size (this=0x2b37fe095c58) at /opt/gcc/include/c++/4.9.3/bits/stl_list.h:887

using a length variable should make it not dependent on stl list implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants