-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/fix the cpp build on windows #109
Fix/fix the cpp build on windows #109
Conversation
Thanks Chris! Consider enabling the workflow on windows then? tsfile/.github/workflows/unit-test.yml Lines 94 to 98 in e17e373
|
Excellent job! |
I guess the probably most important part is to either ask the author of the code snippet to flag his repo as Apache licensed, or to send us a copy of it with an apache license header ... right now it's technically under the GitHub default license and that's not quite compatible with the Apache one. |
Ok ... Windows GitHub Action builds enabled and working (Had to do a minor addition to one of the functions in order to make it work however) |
Ok... I manged to reach the author of the patch and he just set the license of his repo to apache 2.0, so I guess we're good to merge the pr |
…' into fix/fix-the-cpp-build-on-windows
So? We good to merge? |
|
* FIX: Get the windows build working again * FIX: Updated the cmake-generator to match that of IoTDB. * FIX: Reverted to MinGW as there were errors with VisualStudio 17 * fix: Adjusted the code to compile on linux, mac and windows. * feat: Enabled the cpp build on windows in github actions * fix: Tried to fix a compiler error (which however doesn't make much sense) * Removed the comments of license uncertainty. * feat: Removed the unneeded download
* FIX: Get the windows build working again * FIX: Updated the cmake-generator to match that of IoTDB. * FIX: Reverted to MinGW as there were errors with VisualStudio 17 * fix: Adjusted the code to compile on linux, mac and windows. * feat: Enabled the cpp build on windows in github actions * fix: Tried to fix a compiler error (which however doesn't make much sense) * Removed the comments of license uncertainty. * feat: Removed the unneeded download
This PR adds the usage of the cmake-maven-plugin back as well as addresses some code-level changes needed in order to compile TsFile CPP on Windows systems.
Manually tested with
mvnw -P with-cpp clean install
on: