-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC][Frontend] Add a PaddlePaddle Frontend #19
Conversation
``` | ||
import paddle | ||
import paddlehub | ||
model = hub.Module(name="resnet50_vd_imagenet_ssld") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add another one script example showing how to load one paddlepaddle model from disk?
rfcs/add_paddlepaddle_frontend.md
Outdated
paddle.jit.save(model, "model/infer", input_spec=[input_spec]) | ||
``` | ||
|
||
PaddlePaddle's deployment is supported by Paddle Inference/Paddle Lite/OpenVINO/Tengine/Adlik now. We have noticed there are lots of developers convmodel to ONNX format for TVM's supporting, but only part of models can be converted due to the lack of ONNX operators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convmodel
-> converting model; for TVM's supporting
---> supported by TVM
rfcs/add_paddlepaddle_frontend.md
Outdated
``` | ||
|
||
PaddlePaddle's deployment is supported by Paddle Inference/Paddle Lite/OpenVINO/Tengine/Adlik now. We have noticed there are lots of developers convmodel to ONNX format for TVM's supporting, but only part of models can be converted due to the lack of ONNX operators. | ||
Based on this background, we proposed this RFC addle frontend for TVM, improve usability and extend more models support for PaddlePaddle's users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addle-> to add paddlepaddle; improve -> to improve; extend -> to extend
rfcs/add_paddlepaddle_frontend.md
Outdated
mod, params = relay.frontend.from_paddle(model, shape_dict=shape_dict) | ||
``` | ||
|
||
Error may happened if there are some operators is not supported by this frontend, and the details will print out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Errors maybe happened; some operators is -> some operators are
@jiangjiajun Thanks for bringing this rfc, which will help TVM to serve more conveniently for paddlepaddle users. This rfc is good generally speaking. However, there are many spell grammar error so that I suggest you could do one round of proof-reading |
Thanks for your comments, I'll review the RFC this week and update this pull request~ |
cc @mbrookhart who works with paddle before |
Thanks @will-jl944 for revising and polishing this document, it really helps me a lot! @FrozenGene And an example code is provided in |
@jiangjiajun Please go ahead to handle pr. |
@FrozenGene @jiangjiajun please update the file to reflect the RFC number as in other RFCs, please also create a tracking issue per the RFC procedure |
Two followup actionable items per https://github.com/apache/tvm-rfcs#rfc-workflow
|
Okay |
Add a PaddlePaddle frontend for TVM, also I have created a RFC topic in forum where we can discuss at same time.
The related pull request is apache/tvm#8645, still lack of UT, which will be finished in a week.
@tqchen @FrozenGene @junrushao1994 @jcf94