Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for subgraphs. #1221

Merged
merged 12 commits into from
Jun 12, 2018
Merged

add support for subgraphs. #1221

merged 12 commits into from
Jun 12, 2018

Conversation

zheng-da
Copy link
Contributor

@zheng-da zheng-da commented Jun 2, 2018

This PR allows users to provide a subgraph as the input of an operator and save and load a graph with subgraph nodes. The subgraph has to be disjoint with the main graph.

@zheng-da
Copy link
Contributor Author

zheng-da commented Jun 4, 2018

@tqchen @piiswrong could you review the code again?

@zheng-da
Copy link
Contributor Author

zheng-da commented Jun 4, 2018

I tried all unit tests in tests/python/unittest and all of them work fine.

@tqchen
Copy link
Member

tqchen commented Jun 7, 2018

await approval from @piiswrong we want to merge this in so it won't block @zheng-da

@zheng-da zheng-da force-pushed the subgraph branch 2 times, most recently from 64acc33 to dfa479e Compare June 9, 2018 00:09
@junrushao
Copy link
Member

junrushao commented Jun 11, 2018

@tqchen It seems that CI failed because "no space left on device". Could you help with this issue? Thanks!
Update: seems that CI failed because vulkansdk could not be downloaded.

@tqchen
Copy link
Member

tqchen commented Jun 12, 2018

should be fixed, please rebase to trigger build again

@piiswrong piiswrong merged commit 142c7da into apache:master Jun 12, 2018
tqchen pushed a commit to tqchen/tvm that referenced this pull request Jul 6, 2018
* add support for subgraphs.

* fix.

* fix.

* Fix compilation error

* Fix compilation error

* add comments.

* update comments.

* Sanity check on subgraphs when creating IndexedGraph

* avoid the overhead of sanity check.

* Stop using non-recursive DFS

* Trigger CI

* trigger CI
mnuyens pushed a commit to mnuyens/tvm that referenced this pull request Jul 10, 2018
* add support for subgraphs.

* fix.

* fix.

* Fix compilation error

* Fix compilation error

* add comments.

* update comments.

* Sanity check on subgraphs when creating IndexedGraph

* avoid the overhead of sanity check.

* Stop using non-recursive DFS

* Trigger CI

* trigger CI
sergei-mironov pushed a commit to sergei-mironov/tvm that referenced this pull request Aug 8, 2018
* add support for subgraphs.

* fix.

* fix.

* Fix compilation error

* Fix compilation error

* add comments.

* update comments.

* Sanity check on subgraphs when creating IndexedGraph

* avoid the overhead of sanity check.

* Stop using non-recursive DFS

* Trigger CI

* trigger CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants